Fix pausing-resuming logic after queue reordering for concurrency >1 #20

Merged

maleszka merged 5 commits from fix/promoting into main

2026-07-06 22:03:27 +02:00

maleszka commented

2026-07-06 22:03:22 +02:00

Owner

closes #17

maleszka added 5 commits

2026-07-06 22:03:22 +02:00

[spec] research bug related with job promoting with concurrency >1 fa7784df8d

[download] replace session-wide cancel signal with per-entry cancellation 0c433dc46b

cancel_all() previously flipped one watch::channel<bool> shared by every
spawned worker, so pausing one entry to free its slot paused every active
download regardless of concurrency. spawn_pending now gives each worker its
own channel, and cancel_entry(id) signals exactly one. cancel_all() is kept,
reimplemented over the per-entry map, for the graceful-shutdown path that
genuinely needs every worker to stop.

[download] add active-window reconciliation for concurrency > 1 1b45541c70

DownloadQueue::overflow_ids(max_workers) finds Downloading entries pushed
past the active window by a reorder. DownloadSession::reconcile_active_window
cancels exactly those entries via cancel_entry, leaving every other in-flight
download untouched. Not yet wired into the interactive event loop.

[cli] enforce the active-download window on every queue reorder 76b76822a4

pause_for_new_front only ever looked at index 0, so moving an entry into
the active window anywhere but the very front (concurrency > 1) never
paused the entry that should yield its slot. Replace it with
reconcile_active_window at all four reorder/remove call sites (J, K, d,
Enter). Per-entry cancellation from the previous two commits means
spawn_pending no longer needs the awaiting_promote_pause gate: an entry
mid-cancellation stays Downloading until its terminal message lands, so the
Pending|Paused scan already skips it. Drop the flag and the reset it required.

[spec] propagate changes to core_architecture e3e13ab457

Promotes the per-entry cancellation model and active-window reconciliation
from the promoting feature spec: DownloadQueue::overflow_ids and
DownloadSession's cancel_entry/reconcile_active_window replace the retired
cancel_all-precondition/reset_cancel pair in the stable contract. Deletes
specs/features/promoting.md now that its contracts have graduated.

maleszka merged commit f8339d3087 into main

2026-07-06 22:03:27 +02:00

maleszka deleted branch fix/promoting

2026-07-06 22:03:27 +02:00

maleszka referenced this pull request from a commit

2026-07-06 22:03:28 +02:00

Merge pull request 'Fix pausing-resuming logic after queue reordering for concurrency >1' (#20) from fix/promoting into main

maleszka referenced this pull request from a commit

2026-07-06 22:04:15 +02:00

Merge pull request 'Fix pausing-resuming logic after queue reordering for concurrency >1' (#20) from fix/promoting into main